obmc-console design for multi host support

[Kumar Thangavel]

Hi Andrew,

       Thanks for your response and information.

       Please find my response inline below.

Thanks,
Kumar.

-----Original Message-----
From: Andrew Jeffery <andrew at aj.id.au>
Sent: Thursday, February 20, 2020 5:38 AM
To: Kumar Thangavel <thangavel.k at hcl.com>; openbmc at lists.ozlabs.org
Cc: Jeremy Kerr <jk at ozlabs.org>; Joel Stanley <joel at jms.id.au>; Velumani T-ERS,HCLTech <velumanit at hcl.com>
Subject: Re: obmc-console design for multi host support

[CAUTION: This Email is from outside the Organization. Do not click links or open attachments unless you trust the sender.]

Hi Kumar,

On Wed, 19 Feb 2020, at 18:24, Kumar Thangavel wrote:
>
> Hi All,
>
>
>  Obmc-console application current design may not support multi host or
> multiple console. So, we proposed the design to handle multi
> host/multiple console in obmc-console client and server applications.

Thanks for writing a proposal.

>
>  Please find the attached design document.
>
>
>  Could you please review and provide your comments on this.

Interesting timing, because I've actually just solved this problem. Please review this series in Gerrit:

https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerrit.openbmc-project.xyz%2Fq%2Ftopic%3A%2522concurrent-servers%2522%2B(status%3Aopen%2520OR%2520status%3Amerged&data=02%7C01%7Cthangavel.k%40hcl.com%7Cc3bc8632eb5b4b538a3508d7b59904ba%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637177541130921053&sdata=HIYcn2Cd6tgCrAJCUwTaT5AqUkXfrB25HR0ncpsejdg%3D&reserved=0)

Regarding the proposal, I have a few thoughts:

1. Please try to keep it to plain-text
2. If you have code it's best to post it straight away (rather than lead with a proposal and no code)

Kumar : Sure. Will Keep plain text for posting proposals/code.

On point 1, this is an open-source community and sending documents in formats like docx might mean that some people can't access them. Plain- text always works, especially as emails are generally composed that way, which means you can put your proposal directly in an email and people can respond to it with ease.

On point 2, it seems that you've included screenshots of code changes that you have made locally - a few sub-points there:

a. Code is text - you can include snippets of it in your document directly, which removes the need for rich media formats, which removes the need for something like docx.

b. If you've got code, push it to github or gerrit and we can look at it directly!

Kumar : Sure, Will keep code snippets in the plain text or will push it to github or gerrit.

On point b, given that this proposal largely deals with implementation details, it's much more effective if you lead with code and then drive a discussion on the list if necessary. At least this way we have something concrete to point at and argue about, or in the happy case we can just merge it and you've avoided the effort of driving redundant discussion.

Finally, these thoughts are about helping you help us help you to get your code merged with the least amount of effort/friction. Hopefully they are useful to you :)

Kumar : I looked at your patches and this is really good information and very helpful. Will look more in detail and get back to you.

Cheers,

Andrew
::DISCLAIMER::
________________________________
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
________________________________