ipmi command implementation mismatch with the design document
George Hung (洪忠敬)
George.Hung at quantatw.com
Thu Dec 10 19:34:54 AEDT 2020
> On Nov 24, 2020, at 1:06 PM, Vernon Mauery <vernon.mauery at linux.intel.com> wrote:
> On 23-Nov-2020 06:39 AM, Tung Nguyen OS wrote:
>> Although the indicate_no_softoff_needed() can prevent the host from soft off, but it seems like a mismatch b/w the design document and the IPMI implementation.
>> So, my question: is it reasonable for IPMI command ?
> This code has been in place for quite some time now, so I am not sure if the original authors have the context at this point in time. But nobody else has raised this question. git blame says that Andrew Geissler added this feature, but we would have to see if he still knows why.
> commit a6e3a3080d532536e02e304c819c1e17214e038a
> Author: Andrew Geissler <andrewg at us.ibm.com>
> Date: Wed May 31 19:34:00 2017 -0500
> Create file to indicate host requested off/reboot
> Create a file to ensure the soft power off service is
> not run when the host is requesting a power off
> or reboot. There's no need to notify the host (i.e.
> soft power off) when they are initiating it.
> Change-Id: Ic9f8e7110d30f477ceae38bba9d684559d9503d3
> Signed-off-by: Andrew Geissler <andrewg at us.ibm.com>
> I’m wondering if this ties into the discussion in https://github.com/openbmc/phosphor-host-ipmid/issues/158?
> Are you having the same issue Tung? May be time to just put up a commit that does this correctly and discuss via gerrit.
Hi Andrew, I have the same question about ipmi chassis power off,
because according to https://github.com/openbmc/docs/blob/master/designs/state-management-and-external-interfaces.md
Should it be set state transition to "State::Chassis::Transition::Off", not "State::Host::Transition::Off" ?
Or do I miss something I don't know.
>> Best regards,
More information about the openbmc