[PATCH linux dev-5.8 1/2] ARM: dts: aspeed: Add LEDs that are off 9551 on Operator Panel

[Joel Stanley]

On Thu, 13 Aug 2020 at 08:52, Vishwanatha Subbanna
<vishwa at linux.vnet.ibm.com> wrote:
>
> From: Vishwanatha Subbanna <vishwa at linux.ibm.com>
>
> These are LEDs that are controlled by 9551

This patch does not build:

  DTC     arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dtb
../arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts:986.19-1073.4: ERROR
(duplicate_label): /ahb/apb/bus at 1e78a000/i2c-bus at 480/pca9552 at 61:
Duplicate label 'pca1' on /ahb/apb/bus at 1e78a000/i2c-bus at 480/pca9552 at 61
and /ahb/apb/bus at 1e78a000/i2c-bus at 400/pca9551 at 60
ERROR: Input tree has errors, aborting (use -f to force output)


>
> +       pca1: pca9551 at 60 {

As I explained in the last email, this label is a duplicate.

$ git grep "pca1:" arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts:   pca1: pca9551 at 60 {
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts:   pca1: pca9552 at 61 {

You can only have one label called 'pca1' per device tree. You will
need to come up with a naming scheme for each. For example, this could
be called pca_oppanel.

> +               compatible = "nxp,pca9551";
> +               reg = <0x60>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +
> +               gpio at 0 {
> +                       reg = <0>;
> +                       type = <PCA955X_TYPE_GPIO>;
> +               };
> +
> +               gpio at 1 {
> +                       reg = <1>;
> +                       type = <PCA955X_TYPE_GPIO>;
> +               };
> +
> +               gpio at 2 {
> +                       reg = <2>;
> +                       type = <PCA955X_TYPE_GPIO>;
> +               };
> +
> +               gpio at 3 {
> +                       reg = <3>;
> +                       type = <PCA955X_TYPE_GPIO>;
> +               };
> +
> +               gpio at 4 {
> +                       reg = <4>;
> +                       type = <PCA955X_TYPE_GPIO>;
> +               };
> +
> +               gpio at 5 {
> +                       reg = <5>;
> +                       type = <PCA955X_TYPE_GPIO>;
> +               };
> +
> +               gpio at 6 {
> +                       reg = <6>;
> +                       type = <PCA955X_TYPE_GPIO>;
> +               };
> +
> +               gpio at 7 {
> +                       reg = <7>;
> +                       type = <PCA955X_TYPE_GPIO>;
> +               };
> +       };
> +
>         dps: dps310 at 76 {
>                 compatible = "infineon,dps310";
>                 reg = <0x76>;
> --
> 1.8.3.1
>