[PATCH linux dev-5.7 2/2] rainier: Add LEDs that are controlled by ASPEED

[Deepak Kodihalli]

On 13/08/20 8:45 am, Joel Stanley wrote:
> On Wed, 29 Jul 2020 at 11:30, <vishwa at linux.vnet.ibm.com> wrote:
>>
>> From: Vishwanatha Subbanna <vishwa at linux.ibm.com>
>>
>> These are the LEDs that have direct GPIO connection from ASPEED
> 
> Do you mean directly connected to the BMC, and not via a GPIO expander?
> 
> Convetion is to name the patches with a prefix:
> 
>   ARM: dts: aspeed: rainier: Add directly controlled LEDs
> 
> 
>>
>> Signed-off-by: Vishwanatha Subbanna <vishwa at linux.ibm.com>
>> Reviewed-by: Eddie James <eajames at linux.ibm.com>
>> ---
>>   arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 24 ++++++++++++++++++++++--
>>   1 file changed, 22 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>> index 9b28a30..d1a588f 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>> @@ -124,6 +124,26 @@
>>          leds {
>>                  compatible = "gpio-leds";
>>
>> +               /* BMC Card fault LED at the back */
>> +               bmc-ingraham0 {
>> +                       gpios = <&gpio0 ASPEED_GPIO(H, 1) GPIO_ACTIVE_LOW>;
>> +               };
>> +
>> +               /* Enclosure ID LED at the back */
>> +               rear-enc-id0 {
>> +                       gpios = <&gpio0 ASPEED_GPIO(H, 2) GPIO_ACTIVE_LOW>;
>> +               };
>> +
>> +               /* Enclosure fault LED at the back */
>> +               rear-enc-fault0 {
>> +                       gpios = <&gpio0 ASPEED_GPIO(H, 3) GPIO_ACTIVE_LOW>;
>> +               };
>> +
>> +               /* PCIE slot power LED */
>> +               pcieslot-power {
>> +                       gpios = <&gpio0 ASPEED_GPIO(P, 4) GPIO_ACTIVE_LOW>;
>> +               };
>> +
>>                  /* System ID LED that is at front on Op Panel */
>>                  front-sys-id0 {
>>                          retain-state-shutdown;
>> @@ -167,7 +187,7 @@
>>          /*E0-E7*/       "","","","","","","","",
>>          /*F0-F7*/       "","","","","","","","",
>>          /*G0-G7*/       "","","","","","","","",
>> -       /*H0-H7*/       "","","","","","","","",
>> +       /*H0-H7*/       "","bmc-ingraham0","rear-enc-id0","rear-enc-fault0","","","","",
> 
> I think the guideline is to name GPIOs based on their use, so
> bmc-ingraham0 should be fault-bmc-ingraham0 if we follow the psu
> presence GPIO convention of function-name.
> 
> I think we had some documentation written up on naming conventions.

There is 
https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md.

Regards,
Deepak