[PATCH] ARM: dts: aspeed: Add Inspur cp5280g2 BMC machine

Joel Stanley joel at jms.id.au
Wed Apr 22 13:59:28 AEST 2020


On Wed, 22 Apr 2020 at 03:45, John Wang <wangzq.jn at gmail.com> wrote:
>
> The cp5280g2 is an open-power(p8) platform with
> an ast2500 BMC
>
> Signed-off-by: John Wang <wangzqbj at inspur.com>

Looks good.

Can you please send a v2 with the gpio line names for your system?

> +&mac0 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rmii1_default>;
> +       clocks = <&syscon ASPEED_CLK_GATE_MAC1CLK>,
> +                <&syscon ASPEED_CLK_MAC1RCLK>;
> +       clock-names = "MACCLK", "RCLK";
> +       use-ncsi;
> +};
> +
> +&mac1 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> +};

Does this need clocks?


More information about the openbmc mailing list