Call for Gardening Tasks

[James Feist]

On 4/14/2020 6:58 PM, Lei YU wrote:
> On Wed, Apr 15, 2020 at 12:57 AM Patrick Williams <patrick at stwcx.xyz> wrote:
>>
>> On Fri, Apr 10, 2020 at 11:00:48AM -0700, James Feist wrote:
>>> On 4/10/2020 7:30 AM, krtaylor wrote:
>>>> On 4/10/20 9:23 AM, Joseph Reynolds wrote:
>>>>> On 4/9/20 5:19 PM, Vijay Khemka wrote:
>>>
>>> I'd really like to see clang-tidy or other checks for style added into
>>> the build CI. The number of style violations waste lots of time in
>>> code-review for both the submitter and reviewers.
>>
>> Do we have .clang-tidy files in the repositories?  Meson has built-in
>> support for generating a 'ninja clang-tidy' so it is pretty trivial to
>> enable.
> 

There was one here: 
https://github.com/openbmc/bmcweb/blob/70ee8cbd4f3ec5b3e3c18967de221a9f3a70cd38/.clang-tidy

It wasn't perfect, but did move bmcweb over to nearly upstream style. If 
there is a .clang-tidy file we could all agree to, even if it isn't 
perfect, that would be great.


> phosphor-state-manager has .clang-tidy in the repo, and the CI will
> invoke run-clang-tidy.py to do the task.
> However, it's noticed that it's broken with
> https://github.com/openbmc/openbmc-build-scripts/commit/9e5b11f5d5069d244a2dd86b120fcc98fea66d2c
> 

Seems to be empty? Or is meson injecting dependencies somewhere? 
https://github.com/openbmc/phosphor-state-manager/blob/master/.clang-tidy