Re: [PATCH linux dev-5.4 1/3] fsi: master: Remove link enable read-back

Andrew Jeffery andrew at aj.id.au
Fri Apr 10 14:50:18 AEST 2020



On Tue, 7 Apr 2020, at 04:49, Eddie James wrote:
> Both the Aspeed and hub masters read back the link enable register
> after enabling the link, but this is unnecessary, so remove it.

Unfortunately the code isn't commented, but you're making the assertion
that it's not necessary without explaining why. Are we sure it's not
implementing a workaround e.g. to make sure the write is flushed?

Or is this assertion made on the basis that the result is unused?

Andrew


More information about the openbmc mailing list