[PATCH linux dev-5.4 2/2] hwmon: (pmbus/ibm-cffps) Fix LED behavior again

Eddie James eajames at linux.ibm.com
Thu Apr 2 09:03:39 AEDT 2020


Get the driver into the same state as -next. The driver should not
relinquish control of the LEDs to the PSU firmware.

Signed-off-by: Eddie James <eajames at linux.ibm.com>
---
 drivers/hwmon/pmbus/ibm-cffps.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
index 7d3720665ad4..7cf4cc5824ab 100644
--- a/drivers/hwmon/pmbus/ibm-cffps.c
+++ b/drivers/hwmon/pmbus/ibm-cffps.c
@@ -50,13 +50,9 @@
 #define CFFPS_MFR_VAUX_FAULT			BIT(6)
 #define CFFPS_MFR_CURRENT_SHARE_WARNING		BIT(7)
 
-/*
- * LED off state actually relinquishes LED control to PSU firmware, so it can
- * turn on the LED for faults.
- */
-#define CFFPS_LED_OFF				0
 #define CFFPS_LED_BLINK				BIT(0)
 #define CFFPS_LED_ON				BIT(1)
+#define CFFPS_LED_OFF				BIT(2)
 #define CFFPS_BLINK_RATE_MS			250
 
 enum {
-- 
2.24.0



More information about the openbmc mailing list