[PATCH linux dev-5.3 v2 6/8] fsi: aspeed: Fix link enable
Joel Stanley
joel at jms.id.au
Thu Oct 31 16:36:23 AEDT 2019
Link enable was saving the value of the write to result, which was
not checked. It should either have been ignoring the result of the
write, or erroring out if it failed. This chose to error out.
Signed-off-by: Joel Stanley <joel at jms.id.au>
---
drivers/fsi/fsi-master-aspeed.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c
index 8f757eaa6a55..ee760e84c576 100644
--- a/drivers/fsi/fsi-master-aspeed.c
+++ b/drivers/fsi/fsi-master-aspeed.c
@@ -344,7 +344,9 @@ static int aspeed_master_link_enable(struct fsi_master *master, int link)
reg = cpu_to_be32(0x80000000 >> bit);
- result = opb_writel(aspeed, ctrl_base + FSI_MSENP0 + (4 * idx), reg);
+ ret = opb_writel(aspeed, ctrl_base + FSI_MSENP0 + (4 * idx), reg);
+ if (ret)
+ return ret;
mdelay(FSI_LINK_ENABLE_SETUP_TIME);
--
2.24.0.rc1
More information about the openbmc
mailing list