[PATCH qemu aspeed-4.2] hw/arm/aspeed: Fix STRAP2 configuration for Tacoma

Cédric Le Goater clg at kaod.org
Thu Oct 17 17:34:03 AEDT 2019


On 17/10/2019 08:29, Joel Stanley wrote:
> On Thu, 17 Oct 2019 at 06:24, Andrew Jeffery <andrew at aj.id.au> wrote:
>>
>> We were writing the STRAP2 configuration to the STRAP1 property/register
>>
>> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> 
> Nice, I have the same patch in my tree, and forgot about it.
> 
> Reviewed-by: Joel

I will merge this fix in the machine definition patch if you don't mind.

C.
 
> 
>> ---
>>  hw/arm/aspeed.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
>> index ad86ef2eccec..807868224c6c 100644
>> --- a/hw/arm/aspeed.c
>> +++ b/hw/arm/aspeed.c
>> @@ -711,7 +711,7 @@ static void aspeed_machine_tacoma_class_init(ObjectClass *oc, void *data)
>>      mc->desc       = "Aspeed AST2600 EVB (Cortex A7)";
>>      amc->soc_name  = "ast2600-a0";
>>      amc->hw_strap1 = TACOMA_BMC_HW_STRAP1;
>> -    amc->hw_strap1 = TACOMA_BMC_HW_STRAP2;
>> +    amc->hw_strap2 = TACOMA_BMC_HW_STRAP2;
>>      amc->fmc_model = "mx66l1g45g";
>>      amc->spi_model = "mx66l1g45g";
>>      amc->num_cs    = 2;
>> --
>> 2.20.1
>>



More information about the openbmc mailing list