Re: [PATCH linux dev-5.3 v2] soc: aspeed: Fail probe of lpc-ctrl if reserved memory is not aligned

Andrew Jeffery andrew at aj.id.au
Thu Oct 17 10:38:18 AEDT 2019



On Thu, 17 Oct 2019, at 10:05, Andrew Jeffery wrote:
> Alignment is a hardware constraint of the LPC2AHB bridge, and misaligned
> reserved memory will present as corrupted data.
> 
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> ---
> v2: Cosmetic fixes pointed out by Milton
> 
>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts |  2 +-
>  drivers/soc/aspeed/aspeed-lpc-ctrl.c         | 13 +++++++++++++
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts 
> b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index a2eef507ffbb..635744a76884 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -28,7 +28,7 @@
>  
>  		flash_memory: region at 98000000 {
>  			no-map;
> -			reg = <0x98000000 0x04000000>; /* 64M */
> +			reg = <0x99000000 0x04000000>; /* 64M */
>  		};
>  

Agh, v3 inbound.


More information about the openbmc mailing list