Re: [PATCH linux dev-5.3] ARM: dts: aspeed: ast2600evb: Enable i2c buses

Andrew Jeffery andrew at aj.id.au
Wed Oct 16 15:31:29 AEDT 2019



On Wed, 16 Oct 2019, at 14:38, Joel Stanley wrote:
> With the exception of i2c10 and i2c11 which conflict with the pins
> for the third and forth MDIO controllers.
> 
> i2c0 comes has an ADT7490 fan controller/thermal monitor device

Drop "comes"?

> connected. The bus that it appears on depends on jumper settings, so it
> may not be present on all EVBs. It is included to assist testing of I2C.

Initially I read this paragraph as a statement about the hardware rather than
the devicetree and was slightly confused. Maybe say "The devicetree describes
an adt7490 on i2c0, however ..."?

Anyway, with the "comes" grammar fixed:

Reviewed-by: Andrew Jeffery <andrew at aj.id.au>


More information about the openbmc mailing list