[PATCH linux dev-5.3] fsi: aspeed: Add debugfs entries

[Andrew Jeffery]

On Mon, 14 Oct 2019, at 23:18, Brad Bishop wrote:
> at 9:11 PM, Joel Stanley <joel at jms.id.au> wrote:
> 
> > On Mon, 14 Oct 2019 at 00:49, Andrew Jeffery <andrew at aj.id.au> wrote:
> >> On Mon, 14 Oct 2019, at 11:14, Joel Stanley wrote:
> >>> From: Eddie James <eajames at linux.ibm.com>
> >>>
> >>> Add debugfs entries for the FSI master registers.
> >>>
> >>> Signed-off-by: Eddie James <eajames at linux.ibm.com>
> >>> Signed-off-by: Joel Stanley <joel at jms.id.au>
> >>
> >> A bit ugly, but:
> >>
> >> Acked-by: Andrew Jeffery <andrew at aj.id.au>
> >
> > Yes. We will keep it around for in the 5.3 branch to aid with
> > debugging, and drop it in 5.4.
> 
> I’m just curious.  Does the need for code like this go away after FSI  
> bringup is done or when 5.4 rolls in?  Is this just a statement on how it  
> was done or that it was done at all?

I think it's just a statement that there's no plan to carry it indefinitely.

However I think it's fine to keep it, but a) it needs to evolve a little to fix up
bugs in the face of multiple masters as pointed out by Jeremy and b) we
might be able to make it less tedious. And with that it could go upstream.

Hopefully we won't need it much after bringup is done.

Andrew