[PATCH -next v2 1/2] media: aspeed: refine hsync/vsync polarity setting logic
Eddie James
eajames at linux.vnet.ibm.com
Thu Oct 10 00:54:46 AEDT 2019
On 9/13/19 1:11 PM, Jae Hyun Yoo wrote:
> To prevent inaccurate detections of resolution, this commit enables
> clearing of hsync/vsync polarity bits based on probed sync state.
Thanks Jae, looks fine.
Reviewed-by: Eddie James <eajames at linux.ibm.com>
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>
> ---
> Changes since v1:
> * Updated commit message.
>
> drivers/media/platform/aspeed-video.c | 43 +++++++++++++--------------
> 1 file changed, 21 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
> index eb12f3793062..8f77079da55a 100644
> --- a/drivers/media/platform/aspeed-video.c
> +++ b/drivers/media/platform/aspeed-video.c
> @@ -614,7 +614,7 @@ static void aspeed_video_check_and_set_polarity(struct aspeed_video *video)
> int i;
> int hsync_counter = 0;
> int vsync_counter = 0;
> - u32 sts;
> + u32 sts, ctrl;
>
> for (i = 0; i < NUM_POLARITY_CHECKS; ++i) {
> sts = aspeed_video_read(video, VE_MODE_DETECT_STATUS);
> @@ -629,30 +629,29 @@ static void aspeed_video_check_and_set_polarity(struct aspeed_video *video)
> hsync_counter++;
> }
>
> - if (hsync_counter < 0 || vsync_counter < 0) {
> - u32 ctrl = 0;
> + ctrl = aspeed_video_read(video, VE_CTRL);
>
> - if (hsync_counter < 0) {
> - ctrl = VE_CTRL_HSYNC_POL;
> - video->detected_timings.polarities &=
> - ~V4L2_DV_HSYNC_POS_POL;
> - } else {
> - video->detected_timings.polarities |=
> - V4L2_DV_HSYNC_POS_POL;
> - }
> -
> - if (vsync_counter < 0) {
> - ctrl = VE_CTRL_VSYNC_POL;
> - video->detected_timings.polarities &=
> - ~V4L2_DV_VSYNC_POS_POL;
> - } else {
> - video->detected_timings.polarities |=
> - V4L2_DV_VSYNC_POS_POL;
> - }
> + if (hsync_counter < 0) {
> + ctrl |= VE_CTRL_HSYNC_POL;
> + video->detected_timings.polarities &=
> + ~V4L2_DV_HSYNC_POS_POL;
> + } else {
> + ctrl &= ~VE_CTRL_HSYNC_POL;
> + video->detected_timings.polarities |=
> + V4L2_DV_HSYNC_POS_POL;
> + }
>
> - if (ctrl)
> - aspeed_video_update(video, VE_CTRL, 0, ctrl);
> + if (vsync_counter < 0) {
> + ctrl |= VE_CTRL_VSYNC_POL;
> + video->detected_timings.polarities &=
> + ~V4L2_DV_VSYNC_POS_POL;
> + } else {
> + ctrl &= ~VE_CTRL_VSYNC_POL;
> + video->detected_timings.polarities |=
> + V4L2_DV_VSYNC_POS_POL;
> }
> +
> + aspeed_video_write(video, VE_CTRL, ctrl);
> }
>
> static bool aspeed_video_alloc_buf(struct aspeed_video *video,
More information about the openbmc
mailing list