Re: [PATCH linux dev-5.3 4/4] ARM: dts: tacoma: Enable LPC Firmware region

[Andrew Jeffery]

On Wed, 2 Oct 2019, at 19:53, Joel Stanley wrote:
> Required to provide the host firmware to on Tacoma.
> 
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts 
> b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> index 02eeea6a9bd2..55d5227caf69 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> @@ -22,6 +22,17 @@
>  		device_type = "memory";
>  		reg = <0x80000000 0x40000000>;
>  	};
> +
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		flash_memory: region at 98000000 {
> +			no-map;
> +			reg = <0x98000000 0x2000000>; /* 32M */

Should put this at 0xba000000 if we're going to use 32M, or if you want to
use 64M like Rainier then 0xb8000000.

0x98000000 isn't wrong but it fragments the address space more than
necessary.

Andrew