[PATCH linux dev-5.3] ARM: dts: aspeed: rainier: Add i2c eeproms

[Eddie James]

On 10/2/19 11:53 AM, Jinu Thomas wrote:
> Hi Joel,
>
>  This is from the schematics, also it has been tested on rainier 
> simics model. do you still need someone else to review it ?
>
> Regards,
>
> Jinu Joy
>
>
> On 02/10/19 5:39 PM, Joel Stanley wrote:
>> Hello Jinu,
>>
>> On Tue, 1 Oct 2019 at 06:05, Jinu Thomas <jinujoy at linux.vnet.ibm.com> 
>> wrote:
>>>
>>> Added eeproms for the below VPD devices
>>> - BMC
>>> - TPM
>>> - System Planar
>>> - DCM 0 VRM
>>> - DCM 1 VRM
>>> - Base Op panel
>>> - Lcd Op panel
>>>
>>> Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas at in.ibm.com>
>> Your patch looks good. Can you please find someone who has access to
>> the Rainier schematics to review your changes?
>>
>> Cheers,
>>
>> Joel
>>
>>> ---
>>>    arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 35 
>>> ++++++++++++++++++++
>>>    1 file changed, 35 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>>> b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>>> index cdc65eb28d20..7d2f3257b419 100644
>>> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>>> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>>> @@ -53,6 +53,11 @@
>>>
>>>    &i2c0 {
>>>        status = "okay";
>>> +
>>> +        eeprom at 50 {
>>> +                compatible = "atmel,24c64";
>>> +                reg = <0x50>;
>>> +        };
>>>    };
>>>
>>>    &i2c1 {
>>> @@ -262,6 +267,16 @@
>>>            reg = <0x76>;
>>>            #io-channel-cells = <0>;
>>>        };
>>> +
>>> +        eeprom at 50 {
>>> +                compatible = "atmel,24c64";
>>> +                reg = <0x50>;
>>> +        };
>>> +
>>> +        eeprom at 51 {
>>> +                compatible = "atmel,24c64";
>>> +                reg = <0x51>;
>>> +        };


Hi Jinu,

These addresses appear to be lm25066 from the schematic. Also they're 
marked as hotplug? I'm not sure of the significance.


Thanks,

Eddie


>>>    };
>>>
>>>    &i2c8 {
>>> @@ -296,6 +311,16 @@
>>>            compatible = "ti,tmp275";
>>>            reg = <0x4a>;
>>>        };
>>> +
>>> +        eeprom at 50 {
>>> +                compatible = "atmel,24c64";
>>> +                reg = <0x50>;
>>> +        };
>>> +
>>> +        eeprom at 51 {
>>> +                compatible = "atmel,24c64";
>>> +                reg = <0x51>;
>>> +        };
>>>    };
>>>
>>>    &i2c9 {
>>> @@ -340,6 +365,11 @@
>>>            compatible = "infineon,ir35221";
>>>            reg = <0x74>;
>>>        };
>>> +
>>> +        eeprom at 50 {
>>> +                compatible = "atmel,24c64";
>>> +                reg = <0x50>;
>>> +        };
>>>    };
>>>
>>>    &i2c10 {
>>> @@ -384,6 +414,11 @@
>>>            compatible = "infineon,ir35221";
>>>            reg = <0x74>;
>>>        };
>>> +        eeprom at 50 {
>>> +                compatible = "atmel,24c64";
>>> +                reg = <0x50>;
>>> +        };
>>> +
>>>    };
>>>
>>>    &i2c11 {
>>> -- 
>>> 2.20.1 (Apple Git-117)
>>>
>