phosphor-bmc-code-memt: Support redfish remote firmware update with static layout image

[Bright Cheng/WYHQ/Wiwynn]

Dear Adriana and Lei Yu,

We have some questions about submitting code to gerrit, 
1. We add remote to gerrit server using "https://gerrit.openbmc-project.xyz/openbmc/phosphor-bmc-code-mgmt" and try to push the commit to gerrit server.
The result shows that we need to register an email address, but we cannot verify my email address and receive an error 422 (Unprocessable Entity): invalid token.

2. We also try to add remote to gerrit server using "ssh://gerrit.openbmc-project.xyz/openbmc/phosphor-bmc-code-mgmt", but ssh connection cannot be established because timeout.

Could you help us to solve this problem? Thanks!

-----Original Message-----
>> phosphor-bmc-code-memt doesn’t support static-layout remote update 
>> since static layout fw package could only has “image-bmc” in the 
>> package.
> 
> For now, it does support static layout, you just need to upload the 
> tarball contains separated images, instead of the whole "image-bmc"
> tarball.
> 

Checking the build files, the *.static.mtd.all.tar contains the image-bmc, manifest and signature files so yeah we can just upload that file without any build changes, we just need to add the support in the bmc-code-mgmt repo.

>> 
>> 
>> Following are the modifications
>> 
>> 1. Add a name list for static layout only has image-bmc in the fw 
>> package and modify related image file checking.
>> 
>> 2. Add checking ApplyTime property for static layout to decide 
>> whether reboot to apply update process or not.
>> 
>> 
>> 
>> Please find the patch for these modifications in the attachment.

Looks good, if you could just break the patch into two separate patches, one for the supporting image-bmc and one for adding the ApplyTime property, and submit via gerrit as Lei YU pointed. Let us know if you have any questions with the process. Thanks!

> 
> It may be useful to support the whole image as well, so please submit
> the code to gerrit, and we could review the code.
> Please follow
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdocs%2Fblob%2Fmaster%2FCONTRIBUTING.md%23submitting-changes-via-gerrit-server-to-openbmc&data=02%7C01%7CBright_Cheng%40wiwynn.com%7C442ee4941d444751b2fc08d769e4b6ca%7Cde0795e0d7c04eebb9bbbc94d8980d3b%7C1%7C0%7C637094303364000313&sdata=wHVT%2BukHbr0REbsXaoU8QxxNLtSR1yoLcMaWjlZpZYA%3D&reserved=0
> for how to submit changes to gerrit.
> Thanks!

---------------------------------------------------------------------------------------------------------------------------------------------------------------
This email contains confidential or legally privileged information and is for the sole use of its intended recipient. 
Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.
If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.
---------------------------------------------------------------------------------------------------------------------------------------------------------------