entity-manager: adding additional fru formats to fru-device

Brad Bishop bradleyb at fuzziesquirrel.com
Tue Nov 12 06:43:29 AEDT 2019


Hi James

At the OSFC we chatted a little bit about adding support for other fru data formats to fru-device.  I’d like to get started on that.

For background and reference at IBM we call this sort of data “vital product data” or VPD.  Just so we are all on the same page this is the same stuff as IPMI FRU format data, just a different data structure.

When I look at fru-device in the context of adding support for additional data formats, the necessary interface seems to just be a set of key value pairs.  We already have an application that produces exactly that here: https://github.com/openbmc/openpower-vpd-parser

Do you have any thoughts on how you’d like that code brought into EM to the end of supporting the IBM FRU format?  My initial stab without any direction from you would be to:

1 - factor (shared) library logic out from application logic in openpower-vpd-parser
2a - update fru-device to try multiple formats instead of just IPMI when scanning eeproms
2b - add the option to remove support for ipmi or open power fru format parsers
3a - when power format parsing is enabled, link to new openpower-vpd-parser shared library
3b - when ipmi format parsing is enabled, link to existing code (static, not shared)

thx!

-brad


More information about the openbmc mailing list