sel-logger package issue

Bills, Jason M jason.m.bills at linux.intel.com
Wed Nov 6 03:31:29 AEDT 2019


Hi Will,

On 11/5/2019 4:02 AM, Will Liang (梁永鉉) wrote:
> Hi,
> 
> I found that the sel-logger service crashed when the "Value out of range"[1] exception occurred.
> 
> [1]https://github.com/openbmc/phosphor-sel-logger/blob/6afe9560852c6431c43c8e79a28e2b7cb498e355/include/sensorutils.hpp#L166
> 
> It is because the try-catch[2] does not catch the exception type(std::out_of_range).
> Therefore, you can change the catch type to "std::exception" to catch all the exception or only catch the "std::out_of_range" type.
Good catch!  Since the error message is generic, I'm okay with catching 
std::exception (unless others have strong feelings about it).  Please 
submit a patch with the fix.

Thanks!
-Jason

> 
> [2]https://github.com/openbmc/phosphor-sel-logger/blob/6afe9560852c6431c43c8e79a28e2b7cb498e355/include/threshold_event_monitor.hpp#L162
> 
> 
> BRs,
> Will
> 


More information about the openbmc mailing list