x86-power-control

[Vijay Khemka]

On 11/4/19, 11:53 AM, "openbmc on behalf of Bills, Jason M" <openbmc-bounces+vijaykhemka=fb.com at lists.ozlabs.org on behalf of jason.m.bills at linux.intel.com> wrote:

    Hi Vijay,
    
    On 11/1/2019 5:33 PM, Vijay Khemka wrote:
    > Hi Jason/James,
    > I see some limitation in current x86-power-control as we don’t have NMI_OUT, NMI_BUTTON and ID_BUTTON usage. And I am not sure why these are being used. So if I don’t define these in DTS then this program fails. So Please how to disable these. These should be optional. I have following options to disable these.
    > 
    > 1. No returning -1 if we don't find line name, simply move on. I have to see impact on rest of code.
    > 2. Make it compile time flag and should be included through bbappend like -DNMI_OUT etc.
    I chatted with James and I think we like this option the best.  If you 
    set a build flag that is enabled by default, it will let you disable the 
    features you don't need in a .bbappend.  This will let you remove the 
    pins you don't use and still allow for easier detection when an expected 
    pin isn't working.

Thanks Jason, I will work on patch and send it for review.
    
    Thanks,
    -Jason
    
    > 3. Have config Jason file and enable or disable gpio line to be used.
    > 
    > 
    > Please let us know your thought and how should we approach. I am fine with changing this code and submit patch.
    > 
    > Regards
    > -Vijay
    >