Re: [PATCH linux dev-5.3] fsi: aspeed: Clean up defines and documentation

Andrew Jeffery andrew at aj.id.au
Mon Nov 4 15:18:14 AEDT 2019



On Mon, 4 Nov 2019, at 14:41, Joel Stanley wrote:
> On Mon, 4 Nov 2019 at 04:10, Andrew Jeffery <andrew at aj.id.au> wrote:
> >
> >
> >
> > On Mon, 4 Nov 2019, at 14:32, Joel Stanley wrote:
> > > Some of the registers lacked documetation but now can be properly named.
> > >
> > > Rename FW to FULLWORD so no one thinks it means 'firmware'.
> > >
> > > The "enable DMA" comment was setting the FSI access direction for DMA.
> > > As the driver does not yet use DMA it can be removed without effect.
> > >
> > > Signed-off-by: Joel Stanley <joel at jms.id.au>
> >
> > This appears to go on top of my FSI series which goes on top of your other FSI that is a rework of my other FSI series. We should probably start merging these patches :D
> 
> They are all merged, 

Ah, I checked the tree just now and they weren't there.

> with the exception of your alignment one.

What?! How could you not merge that masterpiece?


More information about the openbmc mailing list