[PATCH linux dev-5.3 v2 6/8] fsi: aspeed: Fix link enable
Jeremy Kerr
jk at ozlabs.org
Fri Nov 1 14:20:58 AEDT 2019
Hi Joel,
> Link enable was saving the value of the write to result, which was
> not checked. It should either have been ignoring the result of the
> write, or erroring out if it failed. This chose to error out.
The fix looks good, but should we do this before the introduction of the
readl/writel changes?
Also, it looks like the previous code using both 'reg' and 'ret' as
variable names might be a path to future confusion, maybe we should
avoid that.
Cheers,
Jeremy
More information about the openbmc
mailing list