Cannot find the submit button after "+2"

Brad Bishop bradleyb at fuzziesquirrel.com
Mon May 20 23:31:30 AEST 2019


On Thu, May 16, 2019 at 09:46:50AM +0800, Yong Li wrote:
>Hi Brad,
>
>
>
>On the below code review I submitted, there are "+2" already, but I cannot
>find the submit button on the web page,
>
>
>
>Do I need to apply for other permissions or groups?
>
>
>
>https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/,
>
>
>
>Thanks,
>
>Yong
>

Hi Yong

Whether or not the patch author clicks submit or the maintainer clicks
submit is a matter of maintainer preference.  I prefer to oversee the
merging of changes into the repositories I maintain.  I know that other
maintainers perfer to approve the change but delegate the actual
submission to the patch author (and that is fine).

I'm working on assigning the owner permission to refs/* to the current
repository maintainer for each openbmc repository.  This would allow
each repository maintainer to enable this (or not) as they see fit.

Thanks - brad


More information about the openbmc mailing list