Re: [PATCH qemu] aspeed: add support for a witherspoon-bmc board with 128MB flash chip

[Andrew Jeffery]

On Fri, 17 May 2019, at 01:42, Cédric Le Goater wrote:
> Some Witherspoon boards are shipped with a mt25ql01g flash chip
> holding the BMC firmware.
> 
> Signed-off-by: Cédric Le Goater <clg at kaod.org>

"witherspoon128-bmc" is not very creative, but I can't blame you for that :D

Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

> ---
> 
>  It helps in tracking https://github.com/openbmc/u-boot/issues/18
> 
>  hw/arm/aspeed.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index efc97df00de0..f26215ab5524 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -441,6 +441,17 @@ static const AspeedBoardConfig aspeed_boards[] = {
>          .i2c_init  = witherspoon_bmc_i2c_init,
>          .ram       = 512 * MiB,
>          .num_cpus  = 1,
> +     }, {
> +        .name      = MACHINE_TYPE_NAME("witherspoon128-bmc"),
> +        .desc      = "OpenPOWER Witherspoon128 BMC (ARM1176)",
> +        .soc_name  = "ast2500-a1",
> +        .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,
> +        .fmc_model = "mt25ql01g",
> +        .spi_model = "mx66l1g45g",
> +        .num_cs    = 2,
> +        .i2c_init  = witherspoon_bmc_i2c_init,
> +        .ram       = 512 * MiB,
> +        .num_cpus  = 1,
>      }, {
>          .name      = MACHINE_TYPE_NAME("ast2600-evb"),
>          .desc      = "Aspeed AST2600 EVB (Cortex A7)",
> -- 
> 2.20.1
> 
>