Phosphor pid control

[Vijay Khemka]

I fixed this config file issue, now I am seeing below issue. I will continue to debug but if anyone saw similar issue and have any suggestions, please advise.
root at tiogapass:~# ./swampd 
Sensor: Core_0_CPU1 temp /xyz/openbmc_project/sensors/temperature/Core_0_CPU1 
temp readPath: /xyz/openbmc_project/sensors/temperature/Core_0_CPU1
Sensor: MB_FAN0_TACH fan /xyz/openbmc_project/sensors/fan_tach/MB_FAN0_TACH /xyz/openbmc_project/control/fanpwm/Pwm_1
Sensor: MB_FAN1_TACH fan /xyz/openbmc_project/sensors/fan_tach/MB_FAN1_TACH /xyz/openbmc_project/control/fanpwm/Pwm_2
Sensor: MB_INLET_TEMP temp /xyz/openbmc_project/sensors/temperature/MB_INLET_TEMP 
temp readPath: /xyz/openbmc_project/sensors/temperature/MB_INLET_TEMP
Sensor: MEZZ_SENSOR_REMOTE_TEMP temp /xyz/openbmc_project/sensors/temperature/MEZZ_SENSOR_REMOTE_TEMP 
temp readPath: /xyz/openbmc_project/sensors/temperature/MEZZ_SENSOR_REMOTE_TEMP
Zone Id: 0
PID name: Core 0 CPU1
inputs: Core_0_CPU1, 
PID name: MB_FAN0_TACH
inputs: MB_FAN0_TACH, 
PID name: MB_FAN1_TACH
inputs: MB_FAN1_TACH, 
Bailing during load, missing Zone Configuration
terminate called after throwing an instance of 'std::runtime_error'
  what():  Bailing during load, missing Zone Configuration
Aborted
root at tiogapass:~#

Regards
-Vijay

On 4/30/19, 12:21 PM, "openbmc on behalf of Vijay Khemka" <openbmc-bounces+vijaykhemka=fb.com at lists.ozlabs.org on behalf of vijaykhemka at fb.com> wrote:

    
    
    On 4/30/19, 12:01 PM, "Patrick Venture" <venture at google.com> wrote:
    
        On Tue, Apr 30, 2019 at 11:41 AM Vijay Khemka <vijaykhemka at fb.com> wrote:
        >
        > I checked in code and looks like /usr/share/swampd/config.json file is missing. Where do we get this file from or where is example config.json file?
        
        If you're using the entity-manager to configure it, you wont' need
        that file, but you will need to tell swampd that it's in that mode
        during configuration.
        
        You can add this to your swampd_%.bbappend:
        
        EXTRA_OECONF_append = " --enable-configure-dbus"
    Yes it is enabled in recipes-phosphor/fans/phosphor-pid-control_%.bbappend file.
        
        >
        > On 4/30/19, 11:31 AM, "Patrick Venture" <venture at google.com> wrote:
        >
        >     +James Feist to provide assistance.
        >
        >     On Tue, Apr 30, 2019 at 11:30 AM Vijay Khemka <vijaykhemka at fb.com> wrote:
        >     >
        >     > I have enabled phosphor-pid-control in my image and I see following log
        >     >
        >     >
        >     >
        >     > Apr 12 23:22:43 tiogapass systemd[1]: Started Phosphor-Pid-Control Margin-based Fan Control Daemon.
        >     >
        >     > Apr 12 23:22:46 tiogapass swampd[1072]: terminate called after throwing an instance of 'std::runtime_error'
        >     >
        >     > Apr 12 23:22:46 tiogapass swampd[1072]:   what():  ObjectMapper Call Failure
        >     >
        >     > Apr 12 23:23:04 tiogapass systemd[1]: [[0;1;39m[[0;1;31m[[0;1;39mphosphor-pid-control.service: Main process exited, code=killed, status=6/ABRT[[0m
        >     >
        >     > Apr 12 23:23:04 tiogapass systemd[1]: [[0;1;39m[[0;1;31m[[0;1;39mphosphor-pid-control.service: Failed with result 'signal'.[[0m
        >     >
        >     > Apr 12 23:23:13 tiogapass systemd[1]: phosphor-pid-control.service: Service RestartSec=5s expired, scheduling restart.
        >     >
        >     > Apr 12 23:23:13 tiogapass systemd[1]: phosphor-pid-control.service: Scheduled restart job, restart counter is at 1.
        >     >
        >     > Apr 12 23:23:16 tiogapass systemd[1]: Stopped Phosphor-Pid-Control Margin-based Fan Control Daemon.
        >     >
        >     > Apr 12 23:23:16 tiogapass systemd[1]: Started Phosphor-Pid-Control Margin-based Fan Control Daemon.
        >     >
        >     > Apr 12 23:23:17 tiogapass swampd[1145]: No fan zones, application pausing until reboot
        >     >
        >     > Apr 12 23:23:27 tiogapass swampd[1145]: New configuration detected, restarting
        >     >
        >     > Apr 12 23:23:27 tiogapass swampd[1145]: .
        >     >
        >     > Apr 12 23:23:27 tiogapass systemd[1]: phosphor-pid-control.service: Succeeded.
        >     >
        >     > Apr 12 23:23:32 tiogapass systemd[1]: phosphor-pid-control.service: Service RestartSec=5s expired, scheduling restart.
        >     >
        >     > Apr 12 23:23:32 tiogapass systemd[1]: phosphor-pid-control.service: Scheduled restart job, restart counter is at 2.
        >     >
        >     > Apr 12 23:23:33 tiogapass systemd[1]: Stopped Phosphor-Pid-Control Margin-based Fan Control Daemon.
        >     >
        >     > Apr 12 23:23:33 tiogapass systemd[1]: Started Phosphor-Pid-Control Margin-based Fan Control Daemon.
        >     >
        >     > Apr 12 23:23:34 tiogapass swampd[1183]: No fan zones, application pausing until reboot
        >     >
        >     >
        >     >
        >     >
        >     >
        >     > I have configuration defined through entity manager. What is the best way to debug this and modify configurations.
        >     >
        >     >
        >     >
        >     > Regards
        >     >
        >     > -Vijay
        >
        >