[phosphor-pid-control] scaling issue

[Hank Liou (劉晉翰)]

Hi All,


This issue is related to the repository phosphor-pid-control<https://github.com/openbmc/phosphor-pid-control>.


It is in commit dbuspassive: allow scaling<https://github.com/openbmc/phosphor-pid-control/commit/75eb769d351434547899186f73ff70ae00d7934a> that one added scaling mechanism. However when it comes to pid.cpp<https://github.com/openbmc/phosphor-pid-control/blob/master/pid/ec/pid.cpp>, it may encounter scaling mismatch. That is to say, (in fan control stage) the pid takes the scaled values as inputs, but it utilizes unscaled setpoints resulting wrong error terms. Or just change the setpoint value?


Thanks,


Hank Liou

Quanta Computer Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20190328/c733eda3/attachment.htm>