discuss buildjson code

[Emily Shaffer]

Speaking of making it easier on people, you could have also phrased
this concern as simply a commit to phosphor-pid-control. :)

On Tue, Mar 26, 2019 at 11:23 AM Emily Shaffer <emilyshaffer at google.com> wrote:
>
> Hank,
>
> It looks like you're talking about this file:
> https://github.com/openbmc/phosphor-pid-control/blob/master/pid/buildjson.cpp
>
> Please include at least the project name and even better the source
> code link in the future. OpenBMC has >100 individual repositories and
> it's a lot to ask someone to identify a piece of code by the relative
> filepath within a project.
>
> You can also use the Blame button within github to show who made the
> changes at the lines you're worried about. I can see that pstrinkle
> (venture at google.com) just made the fix after reading your email today,
> though. https://github.com/openbmc/phosphor-pid-control/commit/e3eeef45a722b57d4c3bb379df165e0bd14993bd
>
> As a rule of thumb, in the future when you write the list, please give
> as much information as you can to make it easier on people reading :)
>
> Emily
>
> On Mon, Mar 25, 2019 at 11:34 PM Hank Liou (劉晉翰) <Hank.Liou at quantatw.com> wrote:
> >
> > Hi all,
> >
> > I am reading at the source code of /pid/buildjson.cpp. Is there an error in line 59 and 69? To be precise, I think j should be p since only p has elements positiveHysteresis and negativeHysteresis.
> >
> > Sincerely,
> >
> > Hank Liou
> > Quanta Computer Inc.
>
>
>
> --
> Emily Shaffer



-- 
Emily Shaffer