[phosphor-pid-control] discuss the code in /pid/buildjson.cpp

Patrick Venture venture at google.com
Wed Mar 27 01:00:37 AEDT 2019


On Tue, Mar 26, 2019 at 5:54 AM Hank Liou (劉晉翰) <Hank.Liou at quantatw.com> wrote:
>
> Hi all,
>
> Sorry for insufficient info about my question.
>
> I am reading the source code of /pid/buildjson.cpp in phosphor-pid-control.
>
>
> Is there an error in line 59 and 69? To be precise, I think j should be p since only p has elements positiveHysteresis and negativeHysteresis.

Looks like it.  I'll submit a patchset.

>
> Sincerely,
>
> Hank Liou
> Quanta Computer Inc.


More information about the openbmc mailing list