Legacy OCC numbering

Eddie James eajames at linux.ibm.com
Tue Mar 19 01:26:05 AEDT 2019


On 3/18/19 12:12 AM, Joel Stanley wrote:
> Hi Eddie,
>
> I'm cleaning up the FSI device tree snippets that Ben wrote. There's a comment:
>
>    /* Legacy OCC numbering (to get rid of when userspace is fixed) */
>    &fsi_occ0 {
>            reg = <1>;
>    };
>
> Do you know if these changes have been made to userspace?

I don't think this needs any userspace changes. The "reg" value is coded 
into the dts to make sure that the 2nd processor OCC is always occc2 and 
the 1st processor OCC is always occ1. I don't think that can be removed 
because otherwise there's no way to determine which is which (since the 
probe ordering is not certain). Reading that reg value is in the 
upstream driver, so I think it should be left in the dts.

Thanks,

Eddie

>
> Cheers,
>
> Joel
>



More information about the openbmc mailing list