Re: [PATCH 12/15] ARM: vexpress: fix a leaked reference byaddingmissing of_node_put

wen.yang99 at zte.com.cn wen.yang99 at zte.com.cn
Tue Mar 5 12:27:55 AEDT 2019


> > The call to of_get_next_child returns a node pointer with refcount
> > incremented thus it must be explicitly decremented after the last
> > usage.
> >
> > Detected by coccinelle with the following warnings:
> > ./arch/arm/mach-vexpress/dcscb.c:150:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
> > ./arch/arm/mach-vexpress/dcscb.c:160:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
> > ./arch/arm/mach-vexpress/dcscb.c:171:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
> >
> > Signed-off-by: Wen Yang <wen.yang99 at zte.com.cn>
> > Cc: Liviu Dudau <liviu.dudau at arm.com>
> > Cc: Sudeep Holla <sudeep.holla at arm.com>
> 
> Looks good, assuming you want to take this as a series. Please shout if
> you want us to take this.
> 
> Acked-by: Sudeep Holla <sudeep.holla at arm.com>

Thank you very much, we will submit a v2 series patch that will fix a typo soon:
add a missing space between "adding" and "missing"

--
Regards,
Wen


More information about the openbmc mailing list