[PATCH dev-5.1 v7] ARM: dts: nuvoton: Update Quanta GSJ BMC Device Tree.

[Joel Stanley]

On Tue, 11 Jun 2019 at 13:48, Fran Hsu <franhsutw at gmail.com> wrote:
>
> This patch cleans up the warning message when build GSJ device tree.
> Remove the part of i2c-slave-mqueue from GSJ device tree.
>
> Tested:
>   Build Quanta GSJ image and load on the GSJ BMC module.
>   Ensure that BMC boots to console successful.
>
> Signed-off-by: Fran Hsu <Fran.Hsu at quantatw.com>
> ---
>  arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 18 +++---------------
>  1 file changed, 3 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> index 380d0d382395..497f46d690e9 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> @@ -5,7 +5,7 @@
>  #include "nuvoton-npcm730.dtsi"
>  #include "nuvoton-npcm730-gsj-gpio.dtsi"
>  / {
> -       model = "Quanta GSJ Board (Device Tree v11)";
> +       model = "Quanta GSJ Board (Device Tree v12)";
>         compatible = "nuvoton,npcm750";
>
>         aliases {
> @@ -300,26 +300,14 @@
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
>                                 bus-frequency = <100000>;
> -                               status = "okay";
> -
> -                               ipmb at 40000010 {
> -                                       compatible = "slave-mqueue";
> -                                       reg = <0x40000010>;
> -                                       status = "okay";
> -                               };
> +                               status = "disabled";

There's no reason to have the node listed if you're setting it to
disabled in the dts.

A better cleanup would be to put the description of the i2c buses in
the dtsi, with the nodes disabled. Then in your dts you enable the
nodes that are in use, and add the attached i2c devices.


>                         };
>
>                         i2c14: i2c at 8e000 {
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
>                                 bus-frequency = <100000>;
> -                               status = "okay";
> -
> -                               ipmb at 40000012 {
> -                                       compatible = "slave-mqueue";
> -                                       reg = <0x40000012>;
> -                                       status = "okay";
> -                               };
> +                               status = "disabled";
>                         };
>
>                         i2c15: i2c at 8f000 {
> --
> 2.21.0
>