[PATCH dev-5.1 v5 1/4] ARM: dts: nuvoton: Add NPCM730 common device tree include file.

Tomer Maimon tmaimon77 at gmail.com
Tue Jun 4 20:32:42 AEST 2019


Hi Fran,

I will do my best to test it tomorrow.

Thanks,

Tomer

On Tue, 4 Jun 2019 at 11:31, <franhsutw at gmail.com> wrote:

> Hi Joel,
>     Let me check it and I will update a new patch soon.
> BTW, I had tried to merge these device tree patches into mainline
> (dev-5.2) but built fail.
> I will talk with Tomer to ask for help.
>
> Thanks,
> Fran
>
> > -----Original Message-----
> > From: Joel Stanley <joel at jms.id.au>
> > Sent: Tuesday, June 4, 2019 1:29 PM
> > To: Benjamin Fair <benjaminfair at google.com>
> > Cc: Fran Hsu <franhsutw at gmail.com>; OpenBMC Maillist
> > <openbmc at lists.ozlabs.org>; Fran Hsu <Fran.Hsu at quantatw.com>
> > Subject: Re: [PATCH dev-5.1 v5 1/4] ARM: dts: nuvoton: Add NPCM730 common
> > device tree include file.
> >
> > On Tue, 4 Jun 2019 at 05:23, Joel Stanley <joel at jms.id.au> wrote:
> > >
> > > On Fri, 31 May 2019 at 15:28, Benjamin Fair <benjaminfair at google.com>
> > wrote:
> > > > This looks great! I think it's ready to merge.
> > > >
> > > > On Fri, May 31, 2019 at 6:26 AM Fran Hsu <franhsutw at gmail.com>
> wrote:
> > > > >
> > > > > Quanta GSJ BMC uses the Nuvoton NPCM730 BMC soc.
> > > > > This file describes the common setting of NPCM730 soc.
> > > > >
> > > > > Signed-off-by: Fran Hsu <Fran.Hsu at quantatw.com>
> > > >
> > > > Reviewed-by: Benjamin Fair <benjaminfair at google.com>
> > >
> > > Thanks Benjamin for reviewing, and Fran for working to get these
> > > patches in a state that we can merge them. I've put them in the
> > > dev-5.1 tree with some small tweaks to the commit messages.
> >
> > I spoke too soon. I see these warnings when building:
> >
> > ../arch/arm/boot/dts/nuvoton-npcm730-gsj.dts:307.6-25: Warning
> > (i2c_bus_reg): /ahb/apb/i2c at 8d000/ipmb at 40000010:reg: I2C address must
> > be less than 10-bits, got "0x40000010"
> > ../arch/arm/boot/dts/nuvoton-npcm730-gsj.dts:320.6-25: Warning
> > (i2c_bus_reg): /ahb/apb/i2c at 8e000/ipmb at 40000012:reg: I2C address must
> > be less than 10-bits, got "0x40000012"
> >
> > Please send follow up patches to fix these warnings.
> >
> > The following warnings also exist when building the npcm kernel. If you
> could
> > also fix those it would be appreciated:
> >
> > ../arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:222.22-231.5: Warning
> > (spi_bus_bridge): /ahb/fiu at fb000000: node name for SPI buses should be
> 'spi'
> >   also defined at
> ../arch/arm/boot/dts/nuvoton-npcm730-gsj.dts:81.22-126.5
> > arch/arm/boot/dts/nuvoton-npcm730-gsj.dtb: Warning (spi_bus_reg):
> > Failed prerequisite 'spi_bus_bridge'
> > ../arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:222.22-231.5: Warning
> > (spi_bus_bridge): /ahb/fiu at fb000000: node name for SPI buses should be
> 'spi'
> >   also defined
> > at ../arch/arm/boot/dts/nuvoton-npcm750-evb.dts:164.22-221.5
> > ../arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:233.22-244.5: Warning
> > (spi_bus_bridge): /ahb/fiu at c0000000: node name for SPI buses should be
> 'spi'
> >   also defined
> > at ../arch/arm/boot/dts/nuvoton-npcm750-evb.dts:223.22-242.5
> >
> > Cheers,
> >
> > Joel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20190604/d162d0d9/attachment.htm>


More information about the openbmc mailing list