[PATCH 2/2] ARM: dts: aspeed: tiogapass: Add Riser card

Joel Stanley joel at jms.id.au
Wed Jul 24 08:33:24 AEST 2019


On Tue, 23 Jul 2019 at 17:22, Vijay Khemka <vijaykhemka at fb.com> wrote:
>
> Team,
> This patch also needs review. I separated first patch with v2 and that was acked. Please review this as well.

Do you have a coworker who has access to the schematics and can review
the device tree? They would make a great reviewer.

If no reviewer steps forward I will merge it next time I'm merging patches.

Cheers,

Joel

>
> Regards
> -Vijay
>
> On 7/22/19, 12:41 PM, "Vijay Khemka" <vijaykhemka at fb.com> wrote:
>
>     Added i2c mux for riser card and multiple ava card and its sensor
>     components for Facebook Tiogapass platform
>
>     Signed-off-by: Vijay Khemka <vijaykhemka at fb.com>
>     ---
>      .../dts/aspeed-bmc-facebook-tiogapass.dts     | 230 ++++++++++++++++++
>      1 file changed, 230 insertions(+)
>
>     diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
>     index b7783833a58c..8d0bcb3cd419 100644
>     --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
>     +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
>     @@ -12,6 +12,27 @@
>         aliases {
>                 serial0 = &uart1;
>                 serial4 = &uart5;
>     +
>     +           /*
>     +            * Hardcode the bus number of i2c switches' channels to
>     +            * avoid breaking the legacy applications.
>     +            */
>     +           i2c16 = &imux16;
>     +           i2c17 = &imux17;
>     +           i2c18 = &imux18;
>     +           i2c19 = &imux19;
>     +           i2c20 = &imux20;
>     +           i2c21 = &imux21;
>     +           i2c22 = &imux22;
>     +           i2c23 = &imux23;
>     +           i2c24 = &imux24;
>     +           i2c25 = &imux25;
>     +           i2c26 = &imux26;
>     +           i2c27 = &imux27;
>     +           i2c28 = &imux28;
>     +           i2c29 = &imux29;
>     +           i2c30 = &imux30;
>     +           i2c31 = &imux31;
>         };
>         chosen {
>                 stdout-path = &uart5;
>     @@ -124,6 +145,215 @@
>      &i2c1 {
>         status = "okay";
>         //X24 Riser
>     +   i2c-switch at 71 {
>     +           compatible = "nxp,pca9544";
>     +           #address-cells = <1>;
>     +           #size-cells = <0>;
>     +           reg = <0x71>;
>     +
>     +           imux16: i2c at 0 {
>     +                   #address-cells = <1>;
>     +                   #size-cells = <0>;
>     +                   reg = <0>;
>     +
>     +                   ina219 at 45 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x45>;
>     +                   };
>     +
>     +                   tmp75 at 48 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x48>;
>     +                   };
>     +
>     +                   tmp421 at 49 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x49>;
>     +                   };
>     +
>     +                   eeprom at 50 {
>     +                           compatible = "atmel,24c64";
>     +                           reg = <0x50>;
>     +                           pagesize = <32>;
>     +                   };
>     +
>     +                   i2c-switch at 73 {
>     +                           compatible = "nxp,pca9546";
>     +                           #address-cells = <1>;
>     +                           #size-cells = <0>;
>     +                           reg = <0x73>;
>     +
>     +                           imux20: i2c at 0 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <0>;
>     +                           };
>     +
>     +                           imux21: i2c at 1 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <1>;
>     +                           };
>     +
>     +                           imux22: i2c at 2 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <2>;
>     +                           };
>     +
>     +                           imux23: i2c at 3 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <3>;
>     +                           };
>     +
>     +                   };
>     +
>     +           };
>     +
>     +           imux17: i2c at 1 {
>     +                   #address-cells = <1>;
>     +                   #size-cells = <0>;
>     +                   reg = <1>;
>     +
>     +                   ina219 at 45 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x45>;
>     +                   };
>     +
>     +                   tmp421 at 48 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x48>;
>     +                   };
>     +
>     +                   tmp421 at 49 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x49>;
>     +                   };
>     +
>     +                   eeprom at 50 {
>     +                           compatible = "atmel,24c64";
>     +                           reg = <0x50>;
>     +                           pagesize = <32>;
>     +                   };
>     +
>     +                   i2c-switch at 73 {
>     +                           compatible = "nxp,pca9546";
>     +                           #address-cells = <1>;
>     +                           #size-cells = <0>;
>     +                           reg = <0x73>;
>     +
>     +                           imux24: i2c at 0 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <0>;
>     +                           };
>     +
>     +                           imux25: i2c at 1 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <1>;
>     +                           };
>     +
>     +                           imux26: i2c at 2 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <2>;
>     +                           };
>     +
>     +                           imux27: i2c at 3 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <3>;
>     +                           };
>     +
>     +                   };
>     +
>     +           };
>     +
>     +           imux18: i2c at 2 {
>     +                   #address-cells = <1>;
>     +                   #size-cells = <0>;
>     +                   reg = <2>;
>     +
>     +                   ina219 at 45 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x45>;
>     +                   };
>     +
>     +                   tmp421 at 48 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x48>;
>     +                   };
>     +
>     +                   tmp421 at 49 {
>     +                           compatible = "ti,tmp75";
>     +                           reg = <0x49>;
>     +                   };
>     +
>     +                   eeprom at 50 {
>     +                           compatible = "atmel,24c64";
>     +                           reg = <0x50>;
>     +                           pagesize = <32>;
>     +                   };
>     +
>     +                   i2c-switch at 73 {
>     +                           compatible = "nxp,pca9546";
>     +                           #address-cells = <1>;
>     +                           #size-cells = <0>;
>     +                           reg = <0x73>;
>     +
>     +                           imux28: i2c at 0 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <0>;
>     +                           };
>     +
>     +                           imux29: i2c at 1 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <1>;
>     +                           };
>     +
>     +                           imux30: i2c at 2 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <2>;
>     +                           };
>     +
>     +                           imux31: i2c at 3 {
>     +                                   #address-cells = <1>;
>     +                                   #size-cells = <0>;
>     +                                   reg = <3>;
>     +                           };
>     +
>     +                   };
>     +
>     +           };
>     +
>     +           imux19: i2c at 3 {
>     +                   #address-cells = <1>;
>     +                   #size-cells = <0>;
>     +                   reg = <3>;
>     +
>     +                   i2c-switch at 40 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x40>;
>     +                   };
>     +
>     +                   i2c-switch at 41 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x41>;
>     +                   };
>     +
>     +                   i2c-switch at 45 {
>     +                           compatible = "ti,ina219";
>     +                           reg = <0x45>;
>     +                   };
>     +
>     +           };
>     +
>     +   };
>      };
>
>      &i2c2 {
>     --
>     2.17.1
>
>
>


More information about the openbmc mailing list