Proposal to replace Clang Format with ESLint and Prettier in phosphor-webui

Derick derick.montague at gmail.com
Thu Jul 11 03:17:01 AEST 2019


Thanks Ed for the reviews and support on the GUI tools work! I ran into a
roadblock with the format-code.sh call. I am not finding Prettier as an
Ubuntu
package and won't be able to make the call during the build process.
However,
I am able to use a Git hook to test the code prior to commit and/or push.

I added the npm scripts that can be called for testing and fixing (if
auto-fixable)
so that they can be run from the command line for anyone that doesn't
Prettier
integrated with their code editor (it even has VIM support).

 I have these changes in the Gerrit review
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/22366
and am hoping that this is an acceptable solution.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20190710/9c732eab/attachment.htm>


More information about the openbmc mailing list