[PATCH 00/12] treewide: Fix GENMASK misuses
joe at perches.com
Thu Jul 11 02:01:25 AEST 2019
On Wed, 2019-07-10 at 08:45 -0700, Joe Perches wrote:
> On Wed, 2019-07-10 at 10:43 +0100, Russell King - ARM Linux admin wrote:
> > On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote:
> > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote:
> > > > These GENMASK uses are inverted argument order and the
> > > > actual masks produced are incorrect. Fix them.
> > > >
> > > > Add checkpatch tests to help avoid more misuses too.
> > > >
> > > > Joe Perches (12):
> > > > checkpatch: Add GENMASK tests
> > >
> > > IMHO this doesn't make a lot of sense as a checkpatch test - just throw
> > > in a BUILD_BUG_ON()?
> I tried that.
> It'd can't be done as it's used in declarations
> and included in asm files and it uses the UL()
> I also tried just making it do the right thing
> whatever the argument order.
I also made all those arguments when it was
introduced in 2013.
> Oh well.
More information about the openbmc