[PATCH v2 1/2] dt-binding: iio: add NPCM ADC documentation

Tomer Maimon tmaimon77 at gmail.com
Tue Jan 22 07:20:35 AEDT 2019


Hi Rob,

Thanks for the clarification,

I will remove the rst node and Required Node in the NPCM7xx BMC explanation
from the DT binding.

On Mon, 21 Jan 2019 at 18:12, Rob Herring <robh+dt at kernel.org> wrote:

> On Sun, Jan 20, 2019 at 7:48 PM Joel Stanley <joel at jms.id.au> wrote:
> >
> > On Sat, 19 Jan 2019 at 02:12, Tomer Maimon <tmaimon77 at gmail.com> wrote:
> > >
> > > Hi Joel,
> > >
> > > Thanks for bringing this to my attention,
> > >
> > > I think I will leave it the same way it is now because I will like to
> develop the reset driver and to handle the NPCM7xx SOC resets.
> >
> > You could also do that.
> >
> > But I was suggesting you use a phandle, so you could then find the
> > node you want without searching the entire device tree for the node
> > with the correct compatible.
>
> That's not really any more efficient. You just search the entire tree
> for the matching phandle number instead. Well, that was true until we
> recently added the phandle cache.
>
> In any case, it you plan to move to the reset binding (which would be
> good), then it's better to have nothing in the DT and add something
> rather than change the DT binding.


>
Rob
>

Thanks,

Tomer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20190121/08bd9b77/attachment.html>


More information about the openbmc mailing list