[PATCH v10 10/12] hwmon: Add PECI cputemp driver

Jae Hyun Yoo jae.hyun.yoo at linux.intel.com
Sat Jan 19 06:15:54 AEDT 2019


Hi Miguel,

On 1/18/2019 11:05 AM, Miguel Ojeda wrote:
> Hi Jae,
> 
> On Fri, Jan 18, 2019 at 6:52 PM Jae Hyun Yoo
> <jae.hyun.yoo at linux.intel.com> wrote:
>>
>> I'm assuming you meant:
>>
>> return !(temp->valid && time_before(jiffies, temp->last_updated +
>>                                                UPDATE_INTERVAL));
> 
> Yeah, or return !... || !..., whatever you feel is more comprehensible. :)
> 

Okay, I'll change it like above.

>> Thanks for your review!
> 
> You're welcome! It is just nitpicking, but I thought sending the email
> wouldn't hurt too much (in case you do another version of the series,
> otherwise don't change it just for this! :-)
> 

Currently, I'm making v11 series. I'll address your comments when I
submit the version. Thanks again for your review! :)

Regards,
Jae

> Cheers,
> Miguel
> 


More information about the openbmc mailing list