[PATCH v4 9/9] hwmon (occ): Add sysfs attributes for additional OCC data

Thomas Gleixner tglx at linutronix.de
Fri Jan 18 11:43:52 AEDT 2019


Eddie,

On Wed, 11 Jul 2018, Eddie James wrote:

> --- /dev/null
> +++ b/drivers/hwmon/occ/sysfs.c
> @@ -0,0 +1,188 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * OCC hwmon driver sysfs interface
> + *
> + * Copyright (C) IBM Corporation 2018
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */

The above license information is inconsistent.

The SPDX license identifier says GPL v2 only, but the license notice says
GPL v2 or later. This is just wrong.

Please decide which one to use and please also remove the boiler plate
text. It is redundant.

See Documentation/process/license-rules.rst

Please fix ASAP.

Thanks,

	tglx


More information about the openbmc mailing list