[PATCH dev-4.19 6/6] media: platform: Add Aspeed Video Engine driver

Joel Stanley joel at jms.id.au
Tue Jan 8 13:16:06 AEDT 2019


On Fri, 4 Jan 2019 at 08:54, Eddie James <eajames at linux.ibm.com> wrote:

> +       video->eclk = devm_clk_get(dev, "eclk");
> +       if (IS_ERR(video->eclk)) {
> +               dev_err(dev, "Unable to get ECLK\n");
> +               return PTR_ERR(video->eclk);
> +       }
> +
> +       video->vclk = devm_clk_get(dev, "vclk");
> +       if (IS_ERR(video->vclk)) {
> +               dev_err(dev, "Unable to get VCLK\n");
> +               return PTR_ERR(video->vclk);
> +       }
> +
> +       video->rst = devm_reset_control_get_exclusive(dev, NULL);
> +       if (IS_ERR(video->rst)) {
> +               dev_err(dev, "Unable to get VE reset\n");
> +               return PTR_ERR(video->rst);
> +       }

Once you've fixed the clock you will need to fix this too.

I suggest we do this before merging as it will also lead to device tree changes.


More information about the openbmc mailing list