Increase ARCH_NR_GPIO for ARCH_ASPEED?

[Andrew Jeffery]

On Fri, 22 Feb 2019, at 11:25, Tao Ren wrote:
> Hi Andrew,
> 
> On 2/19/19 4:15 PM, Andrew Jeffery wrote:
> > On Wed, 20 Feb 2019, at 10:43, Tao Ren wrote:
> >> Hi Andrew,
> >>
> >> On 2/17/19 9:11 PM, Andrew Jeffery wrote:
> >>> As an example, for Tiogapass, you should be able to define `CONFIG_ARCH_NR_GPIO = 1024` in tiogapass.cfg:
> >>>
> >>> https://github.com/openbmc/meta-facebook/blob/master/meta-tiogapass/recipes-kernel/linux/linux-aspeed/tiogapass.cfg
> >>
> >> I tried to define 'CONFIG_ARCH_NR_GPIO=1024' in <platform>.cfg, but 
> >> still, it's reset to 0 by "make olddefconfig".
> >>
> >> Below are my steps (using the latest openbmc tree), and kindly let me 
> >> know if I missed something:
> >>
> >> 1) added 'CONFIG_ARCH_NR_GPIO=1024' in 
> >> meta-ibm/meta-romulus/recipes-kernel/linux/linux-aspeed/romulus.cfg
> >> 2) export TEMPLATECONF=meta-ibm/meta-romulus/conf
> >> 3) . openbmc-env
> >> 4) ran "bitbake linux-aspeed"
> >> 5) checked 
> >> build/tmp/work/romulus-openbmc-linux-gnueabi/linux-aspeed/4.19.21+gitAUTOINC+d808d27f70-r0/linux-romulus-standard-build/.config: CONFIG_ARCH_NR_GPIO is reset to 0.
> > 
> > Ugh. I didn't try it myself, was just hoping that would work. Are you okay
> > to keep digging into why?
> 
> Manually editing "ARCH_NR_GPIO" in <platform>.cfg doesn't work because 
> ARCH_NR_GPIO symbol is "invisible" and user defined value will be 
> ignored by "scripts/kconfig/conf". I compared a few other ways to 
> fix/workaround the issue, but IMHO, increasing default ARCH_NR_GPIO for 
> ARCH_ASPEED is better than other solutions. Please suggest.

Hrm. That's really unfortunate. Can you patch it in on your platform for the
moment? We're going to have to come up with some more long term strategy.
Whether that's making the symbol visible or migrating everyone off sysfs
(which they should be doing anyway) I'm not sure. If we don't do either of
those then I think we're going to have to audit userspace to find what will
break.

> 
> BTW, "CONFIG_GCC_PLUGINS=y" in 
> meta-aspeed/recipes-kernel/linux/ast2500/defconfig is not included in 
> the final .config because its dependency option PLUGIN_HOSTCC is not 
> set.

Can you open an issue in https://github.com/openbmc/linux ?

Cheers,

Andrew

> 
> 
> Thanks,
> 
> - Tao
>