Building intel s2600wf image

[Wim Vervoorn]

Hello James,

We got the KCS interface working on the OpenBmc but we are running into an issue we think is a missing part in the OpenBmc implementation at this moment.

We are using the KCS interface and what we see is that the SMS_ATN is set by OpenBmc. This at itself isn't an issue but it isn't cleared.

I don't think the issue is in the KCS driver this correctly implements the set and clear SMS_ATN functions.

From what I see the current implementation of ipmi-host doesn't issue a clear SMS_ATN call anywhere.

I guess this code was developed using the BT interface (in this case the host clears the SMS_ATN).

To solve this the SMS_ATN should be cleared when the message que is empty and when the SetMessageFlags clears all flags.

Is this code already available and nog yet checked in or should we implement this?

Best regards,

Wim Vervoorn

-----Original Message-----
From: James Feist [mailto:james.feist at linux.intel.com] 
Sent: Friday, February 15, 2019 11:08 PM
To: Wim Vervoorn <wvervoorn at eltan.com>; openbmc at lists.ozlabs.org
Subject: Re: Building intel s2600wf image

On 2/15/19 8:31 AM, Wim Vervoorn wrote:
> I noticed that the facebook-tiogapass.dts has the items for kcs2 and 3 included while the s2600wf.dts doesn't assign addresses for these devices (leaving the kcs_addr at 0 causing the driver not to load).
> 
> I this intentional and do start the driver in another way or should I change the dts?

The dts needs to have the kcs nodes added. This hasn't been upstreamed yet. Should look like:

  +&kcs3 {
  +   kcs_addr = <0xCA2>;
  +   status = "okay";
  +};
  +
  +&kcs4 {
  +   kcs_addr = <0xCA4>;
  +   status = "okay";
  +};



Thanks,

James