[PATCH linux dev-4.19] ARM: dts: palmetto: Fix flash_memory region

Joel Stanley joel at jms.id.au
Mon Feb 18 13:47:20 AEDT 2019


On Fri, 15 Feb 2019 at 18:17, Lei YU <mine260309 at gmail.com> wrote:
>
> The flash_memory region was incorrect and exceeds AST2400's RAM range.
> Fix it by putting it before coldfire region, and aligned with 32MiB.

We've had a patch to do this in patchwork for some time now:

https://patchwork.ozlabs.org/patch/879522/

We can't do that as it breaks booting, as the FIT loading will
(sometimes) place the initrd or dtb in the reserved region, and this
stops Linux from being able to map it, causing boot to fail.

We need to fix that bug before we can resolve this issue. There is a
u-boot environment variable that can be set that stops anything being
loaded too high. The proper fix is probably to make u-boot's FIT
loader aware of the reserved mappings and not put things there. Other
suggestions are welcome.

>
> Signed-off-by: Lei YU <mine260309 at gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> index 9285b90..50c9178 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> @@ -32,9 +32,9 @@
>                         no-map;
>                 };
>
> -               flash_memory: region at 98000000 {
> +               flash_memory: region at 5c000000 {
>                         no-map;
> -                       reg = <0x98000000 0x01000000>; /* 16MB */
> +                       reg = <0x5C000000 0x02000000>; /* 32MB */
>                 };
>         };
>
> --
> 2.7.4
>


More information about the openbmc mailing list