Adding new metric definition use case

[vishwa]

hello Piotr,

Could we use the mailing list for those discussions ?

!! Vishwa !!

On 12/5/19 8:39 PM, Matuszczak, Piotr wrote:
> Hi Neeraj,
>
> I've analyzed your use case with Adrian. It looks like you want to define new, synthesized metric from existing D-Bus sensors. We would like to propose a design to implement user-defined metrics, which are synthesized from other metrics using mathematical formulas defined by the user. Such formula may be provided by the user in runtime, not requiring recompilation of OpenBMC. We can discuss  it during the next Telemetry WG meeting.
>
>
> -----Original Message-----
> From: openbmc <openbmc-bounces+piotr.matuszczak=intel.com at lists.ozlabs.org> On Behalf Of Matuszczak, Piotr
> Sent: Tuesday, December 3, 2019 4:42 PM
> To: Neeraj Ladkani <neladk at microsoft.com>
> Cc: openbmc at lists.ozlabs.org; Ambrozewicz, Adrian <adrian.ambrozewicz at intel.com>
> Subject: RE: Adding new metric definition use case
>
> Hi Neeraj,
>
> There are two cases:
> 1. Sensor is already monitored and you want to define new Metric Definition. It is done on the Redfish level. Also in the case when you want to create calculated metric ("Implementation" property equals "Calculated"). In this case min/max/average can be calculated (as defined by the "CalculationAlgorithm" property).
> 2. You want to create Metric Definition for Synthesized sensor ("Implementation" property equals "Synthesized"). This is the example you shown below. In such case, there is no way to provide BMC the algorithm how the metric shall be synthesized from source metrics. In this case, the calculation algorithm has to be implemented as virtual sensor in the BMC prior to defining the Metric Definition. If you want to be able to create synthesized sensors in runtime, additional design will have to be provided.
>
> Regards
> Piotr
>
> -----Original Message-----
> From: Neeraj Ladkani <neladk at microsoft.com>
> Sent: Tuesday, December 3, 2019 8:40 AM
> To: Matuszczak, Piotr <piotr.matuszczak at intel.com>
> Cc: openbmc at lists.ozlabs.org; Ambrozewicz, Adrian <adrian.ambrozewicz at intel.com>
> Subject: RE: Adding new metric definition use case
>
> Hi Piotr,
>
> The use case is simple that if we want to add new metric definition which is already monitored on DBUS and exposed on redfish , we should be able to configure it without changing BMC code.
>
> For example:
> {
>      "@odata.type": "#MetricDefinition.v1_0_3.MetricDefinition",
>      "Id": "OutletAirflowTemp",
>      "Name": "Definition of Outlet Airflow Temperature",
>      "MetricType": "Numeric",
>      "Implementation": "Synthesized",
>      "PhysicalContext": "Exhaust",
>      "Units": "Cel",
>      "Wildcards": [
>          {
>              "Name": "ChassisID",
>              "Values": [
>                  "1"
>              ]
>          }
>      ],
>      "CalculationParameters": [
>          {
>              "SourceMetric": "/redfish/v1/Chassis/{ChassisID}/Thermal#/Temperatures/2/ReadingCelsius"
>          },
>          {
>              "SourceMetric": "/redfish/v1/Chassis/{ChassisID}/Thermal#/Fans/0/Reading"
>          },
>          {
>              "SourceMetric": "/redfish/v1/Chassis/{ChassisID}/Thermal#/Fans/1/Reading"
>          },
>          {
>              "SourceMetric": "/redfish/v1/Chassis/{ChassisID}/Power#/PowerControl/0/PowerConsumedWatts",
>              "ResultMetric": "/redfish/v1/Chassis/{ChassisID}/Power#/PowerControl/0/PowerMetrics/AverageConsumedWatts"
>          }
>      ],
>      "@odata.id": "/redfish/v1/TelemetryService/MetricDefinitions/OutletAirflowTemp",
>      "@Redfish.Copyright": "Copyright 2014-2019 DMTF. For the full DMTF copyright policy, see http://www.dmtf.org/about/policies/copyright."
> }
>
> -----Original Message-----
> From: Matuszczak, Piotr <piotr.matuszczak at intel.com>
> Sent: Thursday, November 28, 2019 3:33 AM
> To: Neeraj Ladkani <neladk at microsoft.com>
> Cc: openbmc at lists.ozlabs.org; Ambrozewicz, Adrian <adrian.ambrozewicz at intel.com>
> Subject: [EXTERNAL] Adding new metric definition use case
>
> Hi Neeraj,
>
> 	As we talked recently during the Telemetry WG meeting, you were asking about adding new metric definitions. Please, let me better understand your use case, you have HW sensor present on the board (for example, let it be CPU0 VR temperature), you have already HWmon reading it and exposing it as the sensor on D-Bus. You want to be able to add the new Metric Definition for proper interpretation of sensor's reading and new metric definition shall also modify sensor's D-Bus parameters (Scale and Unit) ? Do I understand it correctly?
> 	Monitoring Service does not have to interpret the metric from the sensors, because it is used only for report management.
> 	
>
> Piotr Matuszczak
> ---------------------------------------------------------------------
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173, 80-298 Gdansk
> KRS 101882
> NIP 957-07-52-316
>