BMC update via TFTP

[Gunnar Mills]

On 12/3/2019 10:12 AM, Gunnar Mills wrote:
>
>> In BMC WebUI under "Download image file from TFTP server" section,
>> we have text fields "TFTP Server IP address" and "File name".
>> "File name" doesn't take folders in path. Is this a bug or expected 
>> behavior?
>>
>> TFTP downloads work only if file is kept in root of tftp share.
>>
> This is expected.
> https://github.com/openbmc/phosphor-bmc-code-mgmt/blob/b0ce996ac60cf80487d71c3cdb7165d065079377/download_manager.cpp#L33 
>

As long as we continue to sanitize the local filename, I don't see why 
we need to limit the source file name.
Patrick, Adriana, Any objection? Remember why we wrote it this way? I 
assume for simplicity..?

Thanks,
Gunnar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20191203/3a290d99/attachment.htm>