[phosphor-pid-control] scaling issue

[Hank Liou (劉晉翰)]

Hi All,


After commit [1], I found my temp sensor reading would be re-scaled by multiplying 1 over 255, making temperature into unfamiliar unit. Also the fan rpm reading would lie in [0,1] interval, letting the fan input to be 0 (since the input value of fan is from an integer array [2]). Are these normal behaviors? Or do I miss something?


[1] https://github.com/openbmc/phosphor-pid-control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c

[2] https://github.com/openbmc/phosphor-pid-control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontroller.cpp#L86


Thanks,


Hank Liou

Quanta Computer Inc.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20190821/1387009c/attachment.htm>