Adding BuildDate field to entity-manager output

[Patrick Venture]

On Tue, Aug 13, 2019 at 9:31 AM Ed Tanous <ed.tanous at intel.com> wrote:
>
> On 8/13/19 9:09 AM, Patrick Venture wrote:
> > So, with entity-manager you can specify and interface, some properties
> > and how the values should be presented.  For the BuildDate field
> > however, the output from FruDevice for that interface doesn't match
> > the Asset interface's date property format.
> >
> > I merged patch into phosphor-host-ipmid that makes it support parsing
> > multiple formats, however, that dbus interface defines the format "by
> > description."
> >
> > I was curious if it would be worth trying to reinterpret the value
> > when publishing it to that dbus interface?  Converting from "%a %b %e
> > %H:%M:%S %Y" to "%Y-%m-%d - %H:%M:%S"
> >
> > Honestly, I'd be perfectly fine just adding it as-is to the Asset
> > interface description since phosphor-host-ipmid knows how to parse it
> > (pending: https://gerrit.openbmc-project.xyz/24384).
> >
> > Thoughts?
> >
> > Patrick
> >
>
> In theory Entity-manager is just forwarding those fields directly
> through from FruDevice.  It's not surprising they're incorrect;  I don't
> believe there are any uses of them by the external interfaces.  IPMI
> just reads the raw FRU bytes, and Redfish doesn't expose the manufacture
> date at all.
>
> What I suspect is that we just need to make this line conform to the
> right format string.
> https://github.com/openbmc/entity-manager/blob/b8293c016074d19d8579c8ef0e1bfee6dff46ab0/src/FruDevice.cpp#L738
>
> And everything else should "just work"

That's my understanding as well. I Just wanted to make sure the format
wasn't important to anything redfish or out of my scope.

In this case, I'll just swap out the format string with the other one
and it'll just work :)