FruDevice - next device name matching

Patrick Venture venture at google.com
Wed Aug 14 02:06:37 AEST 2019


On Tue, Aug 13, 2019 at 9:05 AM James Feist <james.feist at linux.intel.com> wrote:
>
> On 8/13/19 9:03 AM, Patrick Venture wrote:
> > I wanted to verify this was the expected behavior:
> >
> >        |-/xyz/openbmc_project/FruDevice/Card
> >        |-/xyz/openbmc_project/FruDevice/Card_0
> >        |-/xyz/openbmc_project/FruDevice/Card_01
> >        |-/xyz/openbmc_project/FruDevice/Card_012
> >        |-/xyz/openbmc_project/FruDevice/Card_0123
> >
> > It's fine if that is, albeit in the case where we have 11 cards,
> > that's going to be problematic.  My theory is, it's meant to increment
> > the last number part of the name.  This can be done by a regex parsing
> > of the name string and then pulling out the number, incrementing and
> > tracking the highest number hit.
> >
> > https://github.com/openbmc/entity-manager/blob/master/src/FruDevice.cpp#L869
> >
> > If that's what it should be doing, then I can submit a patch after
> > some testing, I just wanted to verify.
>
> The path name just needs to be different, that patch would be great imo.

Yeah, the code as it stands works fine for this.  The names are unique
and I'm able to properly identify them, etc.

>
> Thanks
>
> James
>
> >
> > Patrick
> >


More information about the openbmc mailing list