[PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver

[Tomer Maimon]

Hi Mark,

Thanks for the prompt reply.

On Thu, 8 Aug 2019 at 16:27, Mark Brown <broonie at kernel.org> wrote:

> On Thu, Aug 08, 2019 at 04:14:48PM +0300, Tomer Maimon wrote:
>
> > +     ctrl->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD
> > +             | SPI_TX_DUAL | SPI_TX_QUAD;
> > +     ctrl->setup = npcm_fiu_setup;
>
> I'm not seeing where we implement dual or quad modes in the driver?
> There's some
>
>
Do you mean you do not see where it is implemented in the NPCM FIU driver?

for example in our driver we modify the access type (singe, dual or quad)
according the op->addr.buswidth
for example in the npcm_fiu_set_drd function.

        regmap_update_bits(fiu->regmap, NPCM_FIU_DRD_CFG,
                           NPCM_FIU_DRD_CFG_ACCTYPE,
                           ilog2(op->addr.buswidth) <<
                           NPCM_FIU_DRD_ACCTYPE_SHIFT);

we also modify it in the UMA R/W functions.

> +     dev_info(dev, "NPCM %s probe succeed\n", fiu->info->name);
>
> Just remove this, it makes the log more verbose but doesn't really add
> any information.
>

I will remove it.

Thanks,

Tomer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20190808/291a6838/attachment-0001.htm>