Calculate BMC MAC address from NCSI NIC's base MAC

Samuel Mendoza-Jonas sam at mendozajonas.com
Mon Aug 5 15:22:07 AEST 2019


On Mon, 2019-08-05 at 04:29 +0000, Joel Stanley wrote:
> Hi Tao,
> 
> On Thu, 1 Aug 2019 at 21:15, Tao Ren <taoren at fb.com> wrote:
> > Hi,
> > 
> > I'm running Facebook Yamp AST2500 BMC and its MAC is connected to
> > Broadcom NCSI-NIC. When CONFIG_NCSI_OEM_CMD_GET_MAC is enabled,
> > BMC's MAC address is calculated by adding 1 to NCSI-NIC's base MAC.
> 
> This would be a good question for the NCSI maintainers. I've added
> Sam
> and Jeremy to cc.
> 
> > This adding-one logic doesn't work for Yamp because Host-BMC MAC
> > offset needs to be 2. What would be the preferred way to fix it?
> > For example:
> > 
> > 1) adding a device tree node (such as "ncsi-bmc-mac-offset") and
> > send it to ncsi stack when calling ncsi_register_dev?
> > 
> > 2) adding a device tree node to be parsed in ncsi stack directly?
> > 
> > 3) adding a KCONFIG option so it can be parsed in ncsi-rsp.c
> > directly?
> > 

Hi Tao,

My first thought is that since this is an OEM-only extension enabled
just by that config option, that perhaps a Kconfig option is the least
obtrusive method to customise the increment.
Any thoughts from other users?

Sam



More information about the openbmc mailing list