[PATCH net 1/2] net: add eth_addr_inc in etherdevice.h
Jakub Kicinski
jakub.kicinski at netronome.com
Wed Apr 24 09:15:13 AEST 2019
On Tue, 23 Apr 2019 22:41:56 +0000, Tao Ren wrote:
> Add eth_addr_inc function in etherdevice.h to increment MAC address. One
> of the use cases is in ncsi stack, where the host's MAC address needs to
> be incremented to get BMC's MAC address.
>
> Signed-off-by: Tao Ren <taoren at fb.com>
Please squash this patch with the next one, IMHO they form a single
logical change together.
> include/linux/etherdevice.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> index e2f3b21cd72a..d48e3a724c54 100644
> --- a/include/linux/etherdevice.h
> +++ b/include/linux/etherdevice.h
> @@ -448,6 +448,19 @@ static inline void eth_addr_dec(u8 *addr)
> u64_to_ether_addr(u, addr);
> }
>
> +/**
> + * eth_addr_inc - Increment the given MAC address
> + *
> + * @addr: Pointer to a six-byte array containing Ethernet address to increment
Please see: Documentation/doc-guide/kernel-doc.rst
Here we need:
- "()" after function name;
- no extra line between function name and argument description.
> + */
> +static inline void eth_addr_inc(u8 *addr)
> +{
> + u64 u = ether_addr_to_u64(addr);
> +
> + u++;
> + u64_to_ether_addr(u, addr);
> +}
> +
> /**
> * is_etherdev_addr - Tell if given Ethernet address belongs to the device.
> * @dev: Pointer to a device structure
More information about the openbmc
mailing list